Skip to content

Fix testDelayVariabilityAppliesToFutureTasks #50667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Fix testDelayVariabilityAppliesToFutureTasks #50667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86b9ed6
Fix testDelayVariabilityAppliesToFutureTasks
DaveCTurner Jan 6, 2020
4043a47
Merge branch 'master' into 2020-01-06-testDelayVariabilityAppliesToFu…
DaveCTurner Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...ork/src/test/java/org/elasticsearch/cluster/coordination/DeterministicTaskQueueTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,20 +376,19 @@ public void testDelayVariabilityAppliesToImmediateTasks() {
public void testDelayVariabilityAppliesToFutureTasks() {
final DeterministicTaskQueue deterministicTaskQueue = newTaskQueue();
advanceToRandomTime(deterministicTaskQueue);
final long delayMillis = randomLongBetween(30000, 60000);
final long variabilityMillis = randomLongBetween(100, 500);
final long nominalExecutionTime = randomLongBetween(0, 60000);
final long variabilityMillis = randomLongBetween(1, 500);
final long startTime = deterministicTaskQueue.getCurrentTimeMillis();
deterministicTaskQueue.setExecutionDelayVariabilityMillis(variabilityMillis);
for (int i = 0; i < 100; i++) {
deterministicTaskQueue.scheduleAt(delayMillis, () -> {});
deterministicTaskQueue.scheduleAt(nominalExecutionTime, () -> {});
}
final long expectedEndTime = deterministicTaskQueue.getLatestDeferredExecutionTime();
assertThat(expectedEndTime, greaterThan(nominalExecutionTime)); // fails if every task has zero variability -- vanishingly unlikely
assertThat(expectedEndTime, lessThanOrEqualTo(Math.max(startTime, nominalExecutionTime + variabilityMillis)));

final long startTime = deterministicTaskQueue.getCurrentTimeMillis();
deterministicTaskQueue.runAllTasks();
final long elapsedTime = deterministicTaskQueue.getCurrentTimeMillis() - startTime;
assertThat(deterministicTaskQueue.getCurrentTimeMillis(), is(expectedEndTime));
assertThat(elapsedTime, greaterThan(delayMillis)); // fails with negligible probability
assertThat(elapsedTime, lessThanOrEqualTo(delayMillis + variabilityMillis));
}

public void testThreadPoolSchedulesPeriodicFutureTasks() {
Expand Down