Fix Snapshot Repository Corruption in Downgrade Scenarios #50692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
added
WIP
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
@ywelsch thanks, all addressed again I think |
tlrx
approved these changes
Jan 9, 2020
...y-multi-version/src/test/java/org/elasticsearch/upgrades/MultiVersionRepositoryAccessIT.java
Outdated
Show resolved
Hide resolved
...y-multi-version/src/test/java/org/elasticsearch/upgrades/MultiVersionRepositoryAccessIT.java
Outdated
Show resolved
Hide resolved
...y-multi-version/src/test/java/org/elasticsearch/upgrades/MultiVersionRepositoryAccessIT.java
Outdated
Show resolved
Hide resolved
...y-multi-version/src/test/java/org/elasticsearch/upgrades/MultiVersionRepositoryAccessIT.java
Outdated
Show resolved
Hide resolved
|
Jenkins run elasticsearch-ci/2 (known unrelated ILM issue) |
|
Jenkins run elasticsearch-ci/2 (known ILM test failure again) |
ywelsch
approved these changes
Jan 9, 2020
|
Thanks Yannick + Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 9, 2020
original-brownbear
added a commit
that referenced
this pull request
Jan 9, 2020
…50797) * Fix Snapshot Repository Corruption in Downgrade Scenarios (#50692) This PR introduces test infrastructure for downgrading a cluster while interacting with a given repository. It fixes the fact that repository metadata in the new format could be written while there's still older snapshots in the repository that require the old-format metadata to be restorable.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 10, 2020
Follow up to elastic#50692 that starts writing a `min_version` field to the `RepositoryData` so that pre-7.6 ES versions can not read it (and potentially corrupt it if they attempt to modify the repo contents) after the repository moved to the new metadata format.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 13, 2020
…lastic#50853) Follow up to elastic#50692 that starts writing a `min_version` field to the `RepositoryData` so that pre-7.6 ES versions can not read it (and potentially corrupt it if they attempt to modify the repo contents) after the repository moved to the new metadata format.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…lastic#50853) Follow up to elastic#50692 that starts writing a `min_version` field to the `RepositoryData` so that pre-7.6 ES versions can not read it (and potentially corrupt it if they attempt to modify the repo contents) after the repository moved to the new metadata format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces test infrastructure for downgrading a cluster while interacting with a given repository.
It fixes the fact that repository metadata in the new format could be written while there's still older snaphshots in the repository that require the old-format metadata to be restorable.
This PR does not yet introduce a new field in
RepositoryDatato avoid old versions from corrupting the repository. That will have to happen in a subsequent PR once the ability to read the newmin_versionfield has been backported to7.6(see related TODO in the diff).Marked
non-issuesince this problem never made it into a release.