Fix and Reenable SnapshotTool Minio Tests #50736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves half of the problem in elastic#46813 by moving the S3 tests to using the shared minio fixture so we at least have some non-3rd-party, constantly running coverage on these tests.
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
pugnascotia
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
The changes look reasonable. I noticed that the minio image we use as a base is almost a year old - have we considered updating it e.g. to RELEASE.2020-01-03T19-12-21Z?
|
Thanks @pugnascotia !
I don't see a reason not to upgrade. But maybe do it a little later (as in a few days after merging this) just in case we run into any test failures from the tool so we didn't change two things at once? :) |
|
Agreed! Just thought I'd mention it since I noticed it. |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 8, 2020
This solves half of the problem in elastic#46813 by moving the S3 tests to using the shared minio fixture so we at least have some non-3rd-party, constantly running coverage on these tests.
original-brownbear
added a commit
that referenced
this pull request
Jan 8, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This solves half of the problem in elastic#46813 by moving the S3 tests to using the shared minio fixture so we at least have some non-3rd-party, constantly running coverage on these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves half of the problem in #46813 by moving the S3
tests to using the shared minio fixture so we at least have
some non-3rd-party, constantly running coverage on these tests.
Sorry for not handling GCS right away as well but it was a little trickier for GCS and I just wanted to reenable these tests as quickly as possible because I'd like to make changes to the underlying test codebase they use.