[Transform] correctly retrieve checkpoints from remote indices #50903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
benwtrent
approved these changes
Jan 13, 2020
| return localIndices; | ||
| } | ||
|
|
||
| public int size() { |
There was a problem hiding this comment.
Suggested change
| public int size() { | |
| public int numClusters() { |
Or something. I thought size() was meant to be the number of total resolved indices, but instead it is used to help allocate the grouped listener.
| client, | ||
| transformConfig.getHeaders(), | ||
| resolvedIndexes.getLocalIndices().toArray(new String[0]), | ||
| "", |
There was a problem hiding this comment.
Suggested change
| "", | |
| LOCAL_CLUSTER_GROUP_KEY, |
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/bwc |
hendrikmuhs
force-pushed
the
transform-ccs-checkpoint
branch
from
c109593 to
4cf7691
Compare
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Jan 14, 2020
…ic#50903) uses remote client(s) to correctly retrieve index checkpoints from remote clusters
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…ic#50903) uses remote client(s) to correctly retrieve index checkpoints from remote clusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses remote client(s) to correctly retrieve index checkpoints from remote clusters