Implement dangling indices API #50920

pugnascotia · 2020-01-13T14:29:17Z

Part of #48366. Implement an API for managing dangling indices.

~~I've been staring at this code for a while so I'd really appreciate some feedback. Note that I haven't (yet) implemented wildcard restores, or written API documentation.~~

…dices-api

elasticmachine · 2020-01-13T14:29:19Z

Pinging @elastic/es-distributed (:Distributed/Recovery)

…dices-api

ywelsch

Thanks for working on this. I've left some comments and items to discuss.

We should break this into smaller reviewable chunks once we agree on the direction.

.eclipseformat.xml

rest-api-spec/src/main/resources/rest-api-spec/api/dangling_indices.delete.json

rest-api-spec/src/main/resources/rest-api-spec/api/dangling_indices.restore.json

...java/org/elasticsearch/action/admin/indices/dangling/TransportDeleteDanglingIndexAction.java

ywelsch · 2020-01-14T15:00:18Z

server/src/main/java/org/elasticsearch/gateway/DanglingIndicesState.java

-            clusterService.addListener(this);
-        } else {
-            logger.warn(AUTO_IMPORT_DANGLING_INDICES_SETTING.getKey() + " is disabled, dangling indices will not be detected or imported");
+        clusterService.addListener(this);


This means that dangling indices scanning is still done on every cluster state update. One of the benefits of this PR was that this now would only needed to be done on-demand, i.e. when a user requests the list of dangling indices, not on every CS update.

This still needs addressing. I agree that we can hunt for dangling indices on demand for the List action, and also load just the specific metadata needed for the Find action. The DanglingIndicesState is effectively a cache, but I don't think we need to cache anything.

We could follow-up with something that checks for dangling indices at startup or periodically if we feel it's needed.

…dices-api

Refer to "importing" dangling indices rather than "restoring" them. Also keeping UUID uppercased in various places, instead of camel-cased.

…dices-api

DaveCTurner

Thanks @pugnascotia, I left a handful of small comments. Apart from that I'm 100% ok with the new APIs and all that infrastructure. I'll need another opinion on the changes to the existing code as I'm finding it very hard to follow all the different states that we can be in while deleting an index.

server/src/main/java/org/elasticsearch/cluster/ClusterChangedEvent.java

...org/elasticsearch/action/admin/indices/dangling/import_index/ImportDanglingIndexRequest.java

...a/org/elasticsearch/action/admin/indices/dangling/list/ListDanglingIndicesResponseTests.java

server/src/main/java/org/elasticsearch/gateway/DanglingIndicesState.java

server/src/test/java/org/elasticsearch/gateway/DanglingIndicesStateTests.java

server/src/main/java/org/elasticsearch/gateway/DanglingIndicesState.java

...g/elasticsearch/action/admin/indices/dangling/delete/TransportDeleteDanglingIndexAction.java

…dices-api

By extending AcknowledgedRequest, it becomes possible to replace ImportDanglingIndexResponse with AcknowledgedResponse.

pugnascotia · 2020-06-09T11:14:30Z

After talking to @DaveCTurner, I've removed the log line in question, as well as fix a test break. I believe there are now no outstanding issues on this PR.

…dices-api

pugnascotia · 2020-06-12T10:58:02Z

@DaveCTurner @ywelsch is there anything else you'd like to see changed on this PR?

ywelsch · 2020-06-16T13:30:33Z

Once this is merged, we should also add the LIST API to the support diagnostics tool.

DaveCTurner

Thanks @pugnascotia, this LGTM :)

ywelsch

I've only checked the core changes in IndicesClusterStateService, ClusterChangedEvent and DanglingIndicesState, which looked good to me.

Backport of #50920. Part of #48366. Implement an API for listing, importing and deleting dangling indices. Co-authored-by: David Turner <[email protected]>

pugnascotia added 19 commits December 9, 2019 12:16

Add an API to fetch dangling indices

cf46736

Refactor list dangling indices to call all nodes

befcfa4

WIP - working on restore API

747908e

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

0d6fb6d

…dices-api

Wow, restores seem to work

4f63acc

Use a better REST model for restores

4843741

Test fix

b335d44

WIP - working on a delete endpoint

ac76ed4

Delete seems to work. Wow.

7419339

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

a520236

…dices-api

Polishing

df9bf02

Check data loss flag after validating an index is dangling

bbef246

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

515dd9b

…dices-api

Check data loss flag when restoring dangling indices

2234641

Ensure nodes are removed before deleting indices

969a87a

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

9847ed1

…dices-api

Add lots of Javadoc

b9b9b97

Add missing license info

eaf940f

Checkstyle

aadc7cc

pugnascotia added :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 labels Jan 13, 2020

pugnascotia requested review from ywelsch and DaveCTurner January 13, 2020 14:29

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

a0aa236

…dices-api

ywelsch suggested changes Jan 14, 2020

View reviewed changes

pugnascotia added 4 commits January 21, 2020 14:03

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

65ef49c

…dices-api

Rename restore to import, uppercase UUID refs

8b27586

Refer to "importing" dangling indices rather than "restoring" them. Also keeping UUID uppercased in various places, instead of camel-cased.

Add node_name and creation_date fields to DanglingIndexInfo

a68b1fa

Convert danling index API request bodies to URL params

a956490

rjernst added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 4, 2020

pugnascotia and others added 2 commits May 15, 2020 11:47

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

ec98df7

…dices-api

Merge branch 'master' into 48366-dangling-indices-api

53611f1

DaveCTurner reviewed Jun 2, 2020

View reviewed changes

ywelsch reviewed Jun 2, 2020

View reviewed changes

pugnascotia added 8 commits June 8, 2020 11:31

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

f80e6da

…dices-api

Use IndexGraveyardDiff to compare graveyards

f8db53f

Change class hierarchy of ImportDanglingIndexRequest

9043ae8

By extending AcknowledgedRequest, it becomes possible to replace ImportDanglingIndexResponse with AcknowledgedResponse.

Replace test strings with random UUIDs

2195c95

Guard against duplicate tombstones for dangling indices

637c3c3

Tweaking

8e2c9fc

Remove unnecessary log line

a8a68fa

Test fixes

593e07c

Merge remote-tracking branch 'upstream/master' into 48366-dangling-in…

56f6617

…dices-api

ywelsch requested review from DaveCTurner and ywelsch June 16, 2020 13:31

DaveCTurner approved these changes Jun 16, 2020

View reviewed changes

ywelsch approved these changes Jun 16, 2020

View reviewed changes

pugnascotia merged commit ebe8951 into elastic:master Jun 16, 2020

pugnascotia deleted the 48366-dangling-indices-api branch June 16, 2020 14:19

pugnascotia added the >enhancement label Jun 16, 2020

pugnascotia mentioned this pull request Jun 16, 2020

Implement dangling indices API #58176

Merged

pugnascotia added the v7.9.0 label Jun 16, 2020

pugnascotia added a commit that referenced this pull request Jun 16, 2020

Implement dangling indices API (#58176)

03369e0

Backport of #50920. Part of #48366. Implement an API for listing, importing and deleting dangling indices. Co-authored-by: David Turner <[email protected]>

russcam mentioned this pull request Jul 23, 2020

7.9.0 Meta ticket elastic/elasticsearch-net#4872

Closed

29 tasks

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement dangling indices API #50920

Implement dangling indices API #50920

pugnascotia commented Jan 13, 2020 •

edited

Loading

elasticmachine commented Jan 13, 2020

ywelsch left a comment

ywelsch Jan 14, 2020

DaveCTurner Feb 27, 2020

DaveCTurner left a comment

pugnascotia commented Jun 9, 2020

pugnascotia commented Jun 12, 2020

ywelsch commented Jun 16, 2020

DaveCTurner left a comment

ywelsch left a comment

Implement dangling indices API #50920

Implement dangling indices API #50920

Conversation

pugnascotia commented Jan 13, 2020 • edited Loading

elasticmachine commented Jan 13, 2020

ywelsch left a comment

Choose a reason for hiding this comment

ywelsch Jan 14, 2020

Choose a reason for hiding this comment

DaveCTurner Feb 27, 2020

Choose a reason for hiding this comment

DaveCTurner left a comment

Choose a reason for hiding this comment

pugnascotia commented Jun 9, 2020

pugnascotia commented Jun 12, 2020

ywelsch commented Jun 16, 2020

DaveCTurner left a comment

Choose a reason for hiding this comment

ywelsch left a comment

Choose a reason for hiding this comment

pugnascotia commented Jan 13, 2020 •

edited

Loading