Add "did you mean" to unknown queries #51177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the message we return for unknown queries with the standard one that we use for unknown fields from `ObjectParser`. This is nice because it includes "did you mean". One day we might convert parsing queries to using object parser, but that looks complex. This change is much smaller and seems useful.
nik9000
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
We had a comment that made a big deal about preserving the error message for unknown queries for backwards compatibility. I'm not actually sure that we offer backwards compatibility in error reporting at all though. At least for now I'm only targeting 8.0 with this. But it is a nice change so maybe it should hit 7.x too? |
|
I talked to @jasontedor and he thinks this is ok to backport. That is good enough for me. |
romseygeek
approved these changes
Jan 18, 2020
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 21, 2020
This replaces the message we return for unknown queries with the standard one that we use for unknown fields from `ObjectParser`. This is nice because it includes "did you mean". One day we might convert parsing queries to using object parser, but that looks complex. This change is much smaller and seems useful.
nik9000
added a commit
that referenced
this pull request
Jan 21, 2020
This replaces the message we return for unknown queries with the standard one that we use for unknown fields from `ObjectParser`. This is nice because it includes "did you mean". One day we might convert parsing queries to using object parser, but that looks complex. This change is much smaller and seems useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the message we return for unknown queries with the standard
one that we use for unknown fields from
ObjectParser. This is nicebecause it includes "did you mean". One day we might convert parsing
queries to using object parser, but that looks complex. This change is
much smaller and seems useful.