Wait for concurrent reads in ESIndexInputTestCase #51425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today `ESIndexInputTestCase#randomReadAndSlice` performs some reads on background threads, but does not necessarily wait for these reads to finish. It's possible that the underlying `IndexInput` may be closed before these reads complete, causing them to fail.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
approved these changes
Jan 24, 2020
|
@elasticmachine please run elasticsearch-ci/2 |
DaveCTurner
deleted the
2020-01-23-fix-indexinputtestcase-returning-before-reading-complete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
ESIndexInputTestCase#randomReadAndSliceperforms some reads onbackground threads, but does not necessarily wait for these reads to finish.
It's possible that the underlying
IndexInputmay be closed before these readscomplete, causing them to fail. This commit fixes that.