Fix the "slices" parameter for the Delete By Query API in the REST specification #51535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecification This patch updates the `type` parameter in the Delete By Query API: according to [the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice), it can be set to "auto", but the type in the documentation allows only numerical values. This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number. The patch uses the `|` notation, which we have discussed previously for encoding a "polymorphic" parameter like this. Related: elastic/go-elasticsearch#77
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
nik9000
approved these changes
Jan 30, 2020
karmi
added a commit
that referenced
this pull request
Feb 2, 2020
…ecification (#51535) This patch updates the `type` parameter in the Delete By Query API: according to [the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice), it can be set to "auto", but the type in the documentation allows only numerical values. This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number. The patch uses the `|` notation, which we have discussed previously for encoding a "polymorphic" parameter like this. Related: elastic/go-elasticsearch#77
karmi
added a commit
that referenced
this pull request
Feb 2, 2020
* REST: Test: Fix the `accept_enterprise` parameter for Get License API (#51527) The Get License API specifies the `accept_enterprise` parameter as a `boolean`: https://github.com/elastic/elasticsearch/blob/0ca5cb8cb636a4be9c36b8e38e565af66abc423b/x-pack/plugin/src/test/resources/rest-api-spec/api/license.get.json#L22-L27 In the test, a `string` is passed however, which makes the test compilation fail in the Go client. (cherry picked from commit e2a2169) * Fix the SQL API documentation in REST specification (#51534) This patch fixes the SQL REST API documentation to conform to the current schema. (cherry picked from commit c8b6a84) * Fix the "slices" parameter for the Delete By Query API in the REST specification (#51535) This patch updates the `type` parameter in the Delete By Query API: according to [the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice), it can be set to "auto", but the type in the documentation allows only numerical values. This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number. The patch uses the `|` notation, which we have discussed previously for encoding a "polymorphic" parameter like this. Related: elastic/go-elasticsearch#77 * Fix the Enrich API documentation in REST specification (#51528) This patch fixes the REST API documentation for the Enrich APIs to conform to the current schema. (cherry picked from commit 59f28f4)
|
should the type for |
|
Yes, absolutely, that was a mistake I did, it's already fixed via https://github.com/elastic/elasticsearch/pull/51792/files. |
karmi
added a commit
that referenced
this pull request
Feb 5, 2020
karmi
added a commit
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
typeparameter in the Delete By Query API: according to the documentation, it can be set to "auto", but the type in the documentation allows only numerical values.This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number.
The patch uses the
|notation, which we have discussed previously for encoding a "polymorphic" parameter like this.Related: elastic/go-elasticsearch#77
/cc @elastic/es-clients