Re-enable plugin and upgrade bats tests #51565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the tests remained in place, the execution of these tests were lost when creating the DistroTestPlugin. This commit restores executing them.
rjernst
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
mark-vieira
approved these changes
Jan 28, 2020
pugnascotia
approved these changes
Jan 29, 2020
We replace the System.out and System.err objects with redirects to our log file, but never ensure they are closed. This commit closes each stream just before replacing it.
|
Can we get this finished off and merged? It's causing a lot of build failues that need triaged. |
rjernst
added a commit
that referenced
this pull request
Feb 15, 2020
The oss and default bats tests were removed, but these references to them remained, causing gradle failures when trying to run packaging tests. While the upgrade and plugins bats tests should still be tested, that is being handled in #51565. This commit removes the outdated references. closes #51974
rjernst
added a commit
that referenced
this pull request
Feb 15, 2020
The oss and default bats tests were removed, but these references to them remained, causing gradle failures when trying to run packaging tests. While the upgrade and plugins bats tests should still be tested, that is being handled in #51565. This commit removes the outdated references. closes #51974
|
@pugnascotia I have been working getting these tests working all week. Unfortunately there were many things broken over the months since they were accidentally disabled. There is still one remaining failure that happens on certain versions with the upgrade tests, which I am still looking into. I pushed 37210c4 to fix #51974, which I did not realize was an issue. |
The packaging tests start elasticsearch in various ways. All of these currently expect it is started asynchronously, yet some tests expect it will fail to start and want to check the error output. This commit adds a daemonize flag to the utility methods to start elasticsearch for such cases, so that when the start method returns, all the error output should already be available since the process will have exited. relates elastic#51716
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 20, 2020
While the tests remained in place, the execution of these tests were lost when creating the DistroTestPlugin. This commit restores executing them.
rjernst
added a commit
that referenced
this pull request
May 20, 2020
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the tests remained in place, the execution of these tests were
lost when creating the DistroTestPlugin. This commit restores executing
them.