Allow Parallel Snapshot Restore And Delete #51608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason not to allow deletes in parallel to restores if they're dealing with different snapshots. A delete will not remove any files related to the snapshot that is being restored if it is different from the deleted snapshot because those files will still be referenced by the restoring snapshot. Loading RepositoryData concurrently to modifying it is concurrency safe nowadays as well since the repo generation is tracked in the cluster state. Closes elastic#41463
original-brownbear
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
| @@ -152,58 +152,4 @@ public void testSnapshottingWithInProgressDeletionNotAllowed() throws Exception | |||
| client().admin().cluster().prepareCreateSnapshot(repo, snapshot2).setWaitForCompletion(true).get(); | |||
| assertEquals(1, client().admin().cluster().prepareGetSnapshots(repo).setSnapshots("_all").get().getSnapshots(repo).size()); | |||
| } | |||
|
|
|||
| public void testRestoreWithInProgressDeletionsNotAllowed() throws Exception { | |||
There was a problem hiding this comment.
Removing this one instead of adjusting it, it's totally redundant to the new resiliency test I added, that proves we don't get a dead-lock in this code either and it's much more useful for debugging.
tlrx
reviewed
Jan 30, 2020
server/src/test/java/org/elasticsearch/snapshots/SnapshotResiliencyTests.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/snapshots/SnapshotResiliencyTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/snapshots/SnapshotResiliencyTests.java
Show resolved
Hide resolved
tlrx
reviewed
Jan 30, 2020
| final StepListener<CreateSnapshotResponse> createSnapshotResponseStepListener = new StepListener<>(); | ||
|
|
||
| continueOrDie(createRepoAndIndex(repoName, index, shards), | ||
| createIndexResponse -> client().admin().cluster().prepareCreateSnapshot(repoName, snapshotName) |
There was a problem hiding this comment.
Should we also index some docs (mostly to generate more snapshot files) before and in-between snapshots, and then run a query?
There was a problem hiding this comment.
Good idea, right now I don't expect it to make a difference but good to have some checks on this :) I pushed e8fe17e
There was a problem hiding this comment.
I don't expect it either but I prefer to have some shard files around :) Thanks
|
Thanks Tanguy + Yannick! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 30, 2020
There is no reason not to allow deletes in parallel to restores if they're dealing with different snapshots. A delete will not remove any files related to the snapshot that is being restored if it is different from the deleted snapshot because those files will still be referenced by the restoring snapshot. Loading RepositoryData concurrently to modifying it is concurrency safe nowadays as well since the repo generation is tracked in the cluster state. Closes elastic#41463
original-brownbear
added a commit
that referenced
this pull request
Jan 30, 2020
There is no reason not to allow deletes in parallel to restores if they're dealing with different snapshots. A delete will not remove any files related to the snapshot that is being restored if it is different from the deleted snapshot because those files will still be referenced by the restoring snapshot. Loading RepositoryData concurrently to modifying it is concurrency safe nowadays as well since the repo generation is tracked in the cluster state. Closes #41463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason not to allow deletes in parallel to restores
if they're dealing with different snapshots.
A delete will not remove any files related to the snapshot that
is being restored if it is different from the deleted snapshot
because those files will still be referenced by the restoring
snapshot.
Also, the snapshot restore is using the
snap-${uuid}.datmetadata in the shardfolders to determine the files to restore, so concurrently modifying shard metadata
isn't an issue as well.
Loading
RepositoryDataconcurrently to modifying it is concurrency-safenowadays as well since the repo generation is tracked in the
cluster state.
Closes #41463
I'd open a follow-up to this one for concurrent snapshot + restore, that will work for the same reasons delete + restore work concurrently.