Fix InternalEngineTests.testSeqNoAndCheckpoints #51630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we force flush while possibly triggering a merge the local checkpoint may change from the expectation from the loop that just increments on every operation. Closes elastic#51604
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
|
Thanks, Armin. I think the problem is that we do not set the start time for indexes and deletes, then a background merge can trigger a flush. |
|
Thanks @dnhatn that is a nicer fix indeed :) |
ywelsch
approved these changes
Jan 30, 2020
|
Thanks Yannick + Nhat! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 30, 2020
* Fix InternalEngineTests.testSeqNoAndCheckpoints If we force flush while possibly triggering a merge the local checkpoint may change from the expectation from the loop that just increments on every operation. Closes elastic#51604
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 30, 2020
* Fix InternalEngineTests.testSeqNoAndCheckpoints If we force flush while possibly triggering a merge the local checkpoint may change from the expectation from the loop that just increments on every operation. Closes elastic#51604
original-brownbear
added a commit
that referenced
this pull request
Jan 30, 2020
original-brownbear
added a commit
that referenced
this pull request
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we force flush in the rarely condition ( https://github.com/elastic/elasticsearch/pull/51630/files#diff-8a78dedbc25426973364f21bdc81c27aL2147) while possibly triggering a merge the local checkpoint may change
from the expectation from the loop that just increments on every operation.
Closes #51604