Always use one shard in vector REST tests. #51643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>test
|
Pinging @elastic/es-search (:Search/Search) |
mayya-sharipova
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Thanks @jtibshirani.
Do we also want to have this PR for 7.7?
|
Thanks for pointing that out, I hadn't realized we cut the branch yet. |
jtibshirani
added a commit
that referenced
this pull request
Jan 29, 2020
This PR tries to address the intermittent vector test failures on 7.x by making sure we create indices with one shard. The fix is based on this theory as to what's happening: * On 7.x, the default number of shards is 1, but in REST tests we randomly use 2 in order to cover the multiple shards case. In the failing test run, we use 2 shards and all documents end up on only one shard. * During a search, the response from the empty shard doesn't produce deprecation warnings because we never try to execute the script. If not all shard responses contain the warning headers, then certain deprecation warnings can be lost (due to the bug described in #33936). Addresses #50716. Relates to #50061.
jtibshirani
added a commit
that referenced
this pull request
Jan 29, 2020
This PR tries to address the intermittent vector test failures on 7.x by making sure we create indices with one shard. The fix is based on this theory as to what's happening: * On 7.x, the default number of shards is 1, but in REST tests we randomly use 2 in order to cover the multiple shards case. In the failing test run, we use 2 shards and all documents end up on only one shard. * During a search, the response from the empty shard doesn't produce deprecation warnings because we never try to execute the script. If not all shard responses contain the warning headers, then certain deprecation warnings can be lost (due to the bug described in #33936). Addresses #50716. Relates to #50061.
jtibshirani
added
:Search Relevance/Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the intermittent vector test failures on 7.x by making
sure we create indices with one shard.
The fix is based on this theory as to what's happening:
2 in order to cover the multiple shards case. In the failing test run, we use 2
shards and all documents end up on only one shard.
deprecation warnings because we never try to execute the script. If not all
shard responses contain the warning headers, then certain deprecation warnings
can be lost (due to the bug described in Response headers missing from search response #33936).
Addresses #50716.
Relates to #50061.