-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Rename ILM history index enablement setting #51698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous setting was `index.lifecycle.history_index_enabled`, this commit changes it to `indices.lifecycle.history_index_enabled` to indicate this is not an index-level setting (it's node level).
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
rjernst
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jan 30, 2020
* Rename ILM history index enablement setting The previous setting was `index.lifecycle.history_index_enabled`, this commit changes it to `indices.lifecycle.history_index_enabled` to indicate this is not an index-level setting (it's node level).
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jan 30, 2020
* Rename ILM history index enablement setting The previous setting was `index.lifecycle.history_index_enabled`, this commit changes it to `indices.lifecycle.history_index_enabled` to indicate this is not an index-level setting (it's node level).
dakrone
added a commit
that referenced
this pull request
Jan 30, 2020
* Rename ILM history index enablement setting The previous setting was `index.lifecycle.history_index_enabled`, this commit changes it to `indices.lifecycle.history_index_enabled` to indicate this is not an index-level setting (it's node level).
dakrone
added a commit
that referenced
this pull request
Jan 30, 2020
* Rename ILM history index enablement setting The previous setting was `index.lifecycle.history_index_enabled`, this commit changes it to `indices.lifecycle.history_index_enabled` to indicate this is not an index-level setting (it's node level).
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Jan 31, 2020
…master_timeout This changes setting name from `index.lifecycle.step.master_timeout` to `indices.lifecycle.step.master_timeout` to avoid confusion about its scope. `index.*` settings are recognized as index level settings, this one is node level. Reletes to elastic#51698
probakowski
added a commit
that referenced
this pull request
Jan 31, 2020
…master_timeout (#51744) * Change index.lifecycle.step.master_timeout to indices.lifecycle.step.master_timeout This changes setting name from `index.lifecycle.step.master_timeout` to `indices.lifecycle.step.master_timeout` to avoid confusion about its scope. `index.*` settings are recognized as index level settings, this one is node level. Reletes to #51698
probakowski
added a commit
that referenced
this pull request
Jan 31, 2020
…master_timeout (#51744) (#51761) * Change index.lifecycle.step.master_timeout to indices.lifecycle.step.master_timeout This changes setting name from `index.lifecycle.step.master_timeout` to `indices.lifecycle.step.master_timeout` to avoid confusion about its scope. `index.*` settings are recognized as index level settings, this one is node level. Reletes to #51698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocker
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
>non-issue
v7.6.0
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous setting was
index.lifecycle.history_index_enabled
, this commit changes it toindices.lifecycle.history_index_enabled
to indicate this is not an index-level setting (it's nodelevel).
Related to #51678