EQL: Fix #51541: [CI] unknown setting [xpack.eql.enabled] in release-tests #51699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
reviewed
Jan 31, 2020
There was a problem hiding this comment.
That didn't work. The style checker complains that we have something that looks like test but tests are not enabled. You can reproduce it quickly with -p x-pack/plugin/eql build.
I would like to propose a slightly different fix for it imotov@378fe80
I am running the full release build at the moment with this fix applied to see if it fixes all issues.
|
Picked up Igor's suggestions. |
imotov
added
:Analytics/EQL
|
Pinging @elastic/es-search (:Search/EQL) |
aleksmaus
added a commit
to aleksmaus/elasticsearch
that referenced
this pull request
Jan 31, 2020
…elease-tests (elastic#51699) Fixes elastic#51541 Co-authored-by: Igor Motov <[email protected]>
aleksmaus
added a commit
that referenced
this pull request
Jan 31, 2020
…tests (#51699) (#51770) Fixes #51541 Co-authored-by: Igor Motov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51541