-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] Adds curl explanation to getting started content #51963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-docs (:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again @lcawl.
[source,js] | ||
-------------------------------------------------- | ||
curl -X<VERB> '<PROTOCOL>://<HOST>:<PORT>/<PATH>?<QUERY_STRING>' -d '<BODY>' | ||
-------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs // NOTCONSOLE
to pass the CI checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Is it worth calling out in the section that talks about submitting REST requests that they can target any node in the cluster? That's true whether or not you use cURL.
Do you mean step 5 in this page or somewhere else in the book? I'll go ahead and merge this PR but am happy to add more clarifications elsewhere hereafter. |
Related to #29698, which mentioned confusion about which nodes to run an API against.
This PR adds content from https://www.elastic.co/guide/en/elasticsearch/guide/2.x/_talking_to_elasticsearch.html#_restful_api_with_json_over_http to the "Getting started with Elasticsearch" content (https://www.elastic.co/guide/en/elasticsearch/reference/master/getting-started.html), since we don't seem to cover that material anywhere else.
Preview:
http://elasticsearch_51963.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/getting-started-install.html#gs-curl