Add unit tests for reading JVM options files #52176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some unit tests to cover the reading of JVM options files.
jasontedor
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
jasontedor
commented
Feb 11, 2020
buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy
Outdated
Show resolved
Hide resolved
jasontedor
commented
Feb 11, 2020
...n/tools/launchers/src/test/java/org/elasticsearch/tools/launchers/JvmOptionsParserTests.java
Show resolved
Hide resolved
This was referenced Feb 11, 2020
mark-vieira
approved these changes
Feb 11, 2020
...n/tools/launchers/src/test/java/org/elasticsearch/tools/launchers/JvmOptionsParserTests.java
Outdated
Show resolved
Hide resolved
...n/tools/launchers/src/test/java/org/elasticsearch/tools/launchers/JvmOptionsParserTests.java
Outdated
Show resolved
Hide resolved
pugnascotia
reviewed
Feb 11, 2020
|
|
||
| if (esJavaOpts != null) { | ||
| jvmOptions.addAll( | ||
| Arrays.stream(esJavaOpts.split("\\s+")).filter(Predicate.not(String::isBlank)).collect(Collectors.toUnmodifiableList()) |
There was a problem hiding this comment.
Maybe?
for (String opt : esJavaOpts.split("\\s+")) {
if (opt.isBlank() == false) {
jvmOptions.add(opt);
}
}
|
There is an open issue for the test that failed here: #52223. Triggering another run. @elasticmachine run elasticsearch-ci/1 |
jasontedor
added a commit
that referenced
this pull request
Feb 12, 2020
This commit adds some unit tests to cover the reading of JVM options files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some unit tests to cover the reading of JVM options files.