Skip to content

Fix timeout in testDowngradeRemoteClusterToBasic #52284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 12, 2020

  • ESCCRRestTestCase#ensureYellow does not work well with assertBusy
  • Increases timeout to 60s

Closes #52036

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v8.0.0 v6.8.7 v7.7.0 v7.6.1 labels Feb 12, 2020
@dnhatn dnhatn requested a review from ywelsch February 12, 2020 19:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CCR)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Feb 13, 2020

Thanks Yannick.

@dnhatn dnhatn merged commit 1342f86 into elastic:master Feb 13, 2020
@dnhatn dnhatn deleted the fix-ccr-timeout branch February 13, 2020 14:05
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 13, 2020
- ESCCRRestTestCase#ensureYellow does not work well with assertBusy
- Increases timeout to 60s

Closes elastic#52036
dnhatn added a commit that referenced this pull request Feb 13, 2020
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 16, 2020
- ESCCRRestTestCase#ensureYellow does not work well with assertBusy
- Increases timeout to 60s

Closes elastic#52036
# Conflicts:
#	x-pack/plugin/ccr/qa/src/main/java/org/elasticsearch/xpack/ccr/ESCCRRestTestCase.java
dnhatn added a commit that referenced this pull request Feb 17, 2020
This commit restores the wait_for_no_initializing_shards check that was 
removed in #52284. We need this condition when waiting for the yellow
status on the follower because we bootstrap the primary shards of the
follower using the snapshot/restore.

Relates #52284
Closes #52126
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 17, 2020
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 17, 2020
This commit restores the wait_for_no_initializing_shards check that was
removed in elastic#52284. We need this condition when waiting for the yellow
status on the follower because we bootstrap the primary shards of the
follower using the snapshot/restore.

Relates elastic#52284
Closes elastic#52126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >test Issues or PRs that are addressing/adding tests v6.8.7 v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants