Filter empty lines from "docker ls" response (#52081) #52373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Filter empty lines from docker ls response In order to cut down on test time, our docker/vagrant tests build the docker image outside of the vagrant VM. When we get around to launching the Vagrant VM, we mount that already-built docker image to a known location. At that point, we need to load the docker image. But we only want to load it once. As we're running tests, we use "docker ls" to check whether the local image is loaded for use. Empty output from the particular ls invocation means no image is loaded. There was a bug in how we checked this. In Java, splitting an empty string will yield an array containing one empty string. So when we're counting the output from the docker ls command, we need to filter out empty lines in order to proceed to loading the image for docker tests.
williamrandolph
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
rjernst
approved these changes
Feb 14, 2020
|
|
||
| final long count = Arrays.stream(result.stdout.split("\n")) | ||
| .map(String::trim) | ||
| .filter(s -> s.isEmpty() == false) |
There was a problem hiding this comment.
nit: This can be simplified as .filter(not(String::isEmpty))
|
@elasticmachine run elasticsearch-ci/packaging-matrix-windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to cut down on test time, our docker/vagrant tests build the
docker image outside of the vagrant VM. When we get around to launching
the Vagrant VM, we mount that already-built docker image to a known
location. At that point, we need to load the docker image. But we only
want to load it once. As we're running tests, we use "docker ls" to
check whether the local image is loaded for use. Empty output from the
particular ls invocation means no image is loaded.
There was a bug in how we checked this. In Java, splitting an empty
string will yield an array containing one empty string. So when we're
counting the output from the docker ls command, we need to filter out
empty lines in order to proceed to loading the image for docker tests.
gradle check?