Skip to content

[Transform] Integration tests: forward audit messages to logs #52394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hendrikmuhs
Copy link

audit messages are stored in the notifications index, so audit information is lost for integration tests. This change forwards audit messages to logs, so they can help to debug issues.

relates: #51627

Notes: the real changes are in both logAudits() methods, remaining changes are from applying code formatting

@hendrikmuhs hendrikmuhs added >test Issues or PRs that are addressing/adding tests v8.0.0 :ml/Transform Transform v7.7.0 labels Feb 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs merged commit c222631 into elastic:master Feb 18, 2020
@hendrikmuhs hendrikmuhs deleted the transform-test-forward-audit-logs branch February 18, 2020 07:45
hendrikmuhs pushed a commit that referenced this pull request Feb 18, 2020
audit messages are stored in the notifications index, so audit information is lost for integration
tests. This change forwards audit messages to logs, so they can help to debug issues.

relates: #51627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants