[Transform] add support for filter aggregation #52483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
benwtrent
reviewed
Feb 18, 2020
...src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/AggregationResultUtils.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
force-pushed
the
transform-filter-support
branch
from
78b63e3 to
68aeabe
Compare
benwtrent
approved these changes
Feb 20, 2020
| subAgg.getName(), | ||
| getExtractor(subAgg).value( | ||
| subAgg, | ||
| fieldTypeMap.get(subLookupFieldPrefix + "." + subAgg.getName()), |
There was a problem hiding this comment.
It strikes me that supplying fieldType is no longer necessary.
Anything that desires to know fieldType could look it up via its own agg name combined with the prefix (if not empty).
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/bwc |
2 similar comments
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/bwc |
added 7 commits
February 21, 2020 12:01
hendrikmuhs
force-pushed
the
transform-filter-support
branch
from
8f444d7 to
0d8d6d0
Compare
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 21, 2020
add support for filter aggregations, refactor code for sub-aggregation support in mapping deduction fixes #52151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for filter aggregations, refactor code for sub-aggregation support in mapping deduction
fixes #52151
Note: Dear reviewer, please start with 78b63e3