Skip to content

Rename .ml-state index to .ml-state-000001 to support rollover #52510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2020

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Feb 19, 2020

This PR changes the name of the state index from .ml-state to .ml-state-000001 so that the rollover can be performed on the index.
The state index pattern (.ml-state*) is still valid as it "catches" both legacy and new name.
If the user already has the legacy state index (.ml-state), we will not create the new one (.ml-state-000001).

This PR doesn't create any ILM policy nor does it invoke the rollover action. It can be viewed as a prerequisite for implementing either ILM or rollover.

Relates #29938

@przemekwitek przemekwitek force-pushed the initial_ml_state branch 2 times, most recently from d617f09 to c209972 Compare February 19, 2020 13:12
@przemekwitek przemekwitek changed the title Create .ml-state-000001 index instead of .ml-state Rename .ml-state index to .ml-state-000001 to support rollover Feb 19, 2020
@przemekwitek przemekwitek force-pushed the initial_ml_state branch 3 times, most recently from 1f9eb98 to b2e6c55 Compare February 20, 2020 12:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek przemekwitek marked this pull request as ready for review February 20, 2020 12:38
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you could just add the realistic settings and mappings (and of course get the tests to pass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants