reduce bytes used when serializing Extent #52549
Conversation
talevy
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
| negLeft = Math.toIntExact(posRight - input.readVLong()); | ||
| posLeft = 0; | ||
| negRight = 0; | ||
| break; | ||
| default: | ||
| case ALL_SET: | ||
| posRight = input.readVInt(); | ||
| posLeft = Math.toIntExact(posRight - input.readVLong()); | ||
| negRight = input.readInt(); | ||
| negLeft = Math.toIntExact(negRight - input.readVLong()); |
There was a problem hiding this comment.
we should probably update ALL_SET to have the same logic as POSITIVE_SET and NEGATIVE_SET combined?
There was a problem hiding this comment.
updated to what I think you meant
There was a problem hiding this comment.
Actually I was thinking of doing this:
posLeft = input.readVInt();
posRight = Math.toIntExact(input.readVLong() + posLeft);
negRight = -input.readVInt();
negLeft = Math.toIntExact(negRight - input.readVLong());
There is no reason to serialize posLeft/posRight differently in the POSITIVE_SET case or in the ALL_SET case? And likewise for negLeft/negRight in the NEGATIVE_SET or ALL_SET cases?
There was a problem hiding this comment.
my bad. I misunderstood. will update thanks
|
@jpountz thanks for the suggestions. I did a rough speed/size test of these changes and found the following before changes: writeSpeed: 172.679105 ns after changes: writeSpeed: 169.303268 ns |
|
@elasticmachine run elasticsearch-ci/1 |
This commit reflects comments made by Adrien in #50834 surrounding the Extent serialization. it re-orders and negates a few values in order to save more space
This commit reflects comments made by Adrien in #50834 surrounding the Extent serialization.
it re-orders and negates a few values in order to save more space