Fix testResyncAfterPrimaryPromotion #52615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
dnhatn
commented
Feb 21, 2020
| @@ -378,7 +377,7 @@ public void testResyncAfterPrimaryPromotion() throws Exception { | |||
| assertThat(source.source.utf8ToString(), is("{ \"f\": \"normal\"}")); | |||
| } | |||
| } | |||
| assertThat(translogOperations, is(initialDocs + extraDocs)); | |||
There was a problem hiding this comment.
I spent some time to separate these two expectations, but it was more complicated than I thought. I think it's fine to assert like this.
@elasticmachine run elasticsearch-ci/1 |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 26, 2020
Adjusts the assertion as we might eagerly clean up translog during resync since elastic#52556 Relates elastic#52556 Closes elastic#52598
dnhatn
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the assertion as we might eagerly clean up translog during resync since #52556
Relates #52556
Closes #52598