add explicit tests for geo_shape with doc values on old indices #52861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
WIP
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
iverase
reviewed
Feb 28, 2020
| } | ||
|
|
||
| public void test7xIndexWith8Index() { | ||
| SearchResponse response = client().prepareSearch(IDX_NAME_7x, IDX_NAME) |
There was a problem hiding this comment.
Not sure if am reading this correctly. If you mix index with different versions then we do not fail? Is this the expected behavior?
There was a problem hiding this comment.
I think this is intentional? We fail shards that do not have doc-values, but since the other index is valid, the aggregation result is consistent.
It errors out if queried against an index with no geo_shape field at all.
I will double check other aggregations to see what is the most consistent behavior. I assume it is the same as is shown here
There was a problem hiding this comment.
I see, and this assertion checks that some shards were not successful:
assertThat(response.getSuccessfulShards(), lessThan(response.getTotalShards()));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests to verify behavior of geo-aggregations on indices that have
doc-values disabled by default due to an old index version.
the version bounds to 7.x can be updated after merge of
geoshape-doc-valuesinto master