Add ObjectParser.declareNamedObject (singular) method #53017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
v8.0.0
v7.7.0
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
I'm not sure which team owns this code, I've gone for search why not |
|
run elasticsearch-ci/bwc |
davidkyle
force-pushed
the
single-obj-parser
branch
from
b1ffc1b to
129ba9d
Compare
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
|
I pinged the core-infra team, since they might be interested in reviewing this change. |
jtibshirani
removed
the
:Search/Search
|
@nik9000 Would you please review this? |
davidkyle
force-pushed
the
single-obj-parser
branch
from
129ba9d to
f6656fa
Compare
nik9000
approved these changes
Mar 10, 2020
| @@ -403,7 +425,7 @@ public void declareField(Parser<Value, Context> p, ParseField parseField, ValueT | |||
| throw new XContentParseException(p.getTokenLocation(), "[" + field + "] can be a single object with any number of " | |||
| + "fields or an array where each entry is an object with a single field"); | |||
| } | |||
| // This messy exception nesting has the nice side effect of telling the use which field failed to parse | |||
| // This messy exception nesting has the nice side effect of telling the user which field failed to parse | |||
|
Thanks @nik9000 |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Mar 11, 2020
Add the convenience method AbstractObjectParser.declareNamedObject (singular) to complement the existing declareNamedObjects (plural).
This was referenced Mar 11, 2020
davidkyle
added a commit
that referenced
this pull request
Mar 12, 2020
Fixes a bug in #53017 where ObjectParser.parseNamedObject would leave the end object token unconsumed meaning subsequent fields would not be parsed.
davidkyle
added a commit
that referenced
this pull request
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the method
AbstractObjectParser.declareNamedObject(singular) to complement the existingdeclareNamedObjects(plural). This is a convenience to avoid hacking around withdeclareNamedObject*s*.Also a small refactoring to avoid duplicated code in
ConstructingObjectParser.declareNamedObject..methods.