Skip to content

EQL: consistent naming for event type vs event category #53073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

aleksmaus
Copy link
Contributor

Related to #52941

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/EQL)

@aleksmaus aleksmaus requested a review from jrodewig March 3, 2020 19:01
@jrodewig
Copy link
Contributor

jrodewig commented Mar 3, 2020

Excited about these changes. I'll work on syncing up the existing docs to match the new field name + defaults. Thanks @aleksmaus.

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotov
Copy link
Contributor

imotov commented Mar 3, 2020

@elasticmachine run elasticsearch-ci/default-distro

@aleksmaus aleksmaus merged commit 82c645e into elastic:master Mar 4, 2020
aleksmaus added a commit to aleksmaus/elasticsearch that referenced this pull request Mar 4, 2020
jrodewig added a commit that referenced this pull request Mar 4, 2020
Updates the documented default `event_category_field` and `timestamp_field`
values for the EQL search API. Also updates related guidance in the
EQL requirement docs.

Relates to #53073.
jrodewig added a commit that referenced this pull request Mar 4, 2020
Updates the documented default `event_category_field` and `timestamp_field`
values for the EQL search API. Also updates related guidance in the
EQL requirement docs.

Relates to #53073.
jrodewig added a commit that referenced this pull request Mar 5, 2020
* [DOCS] Document `any` keyword in EQL syntax

Adds documentation for the `any` keyword to the EQL syntax docs.

Includes:

* Definition of an event type and its relationship to the event type
  field.
* Example matching all event types using `any` keyword
* Example matching event types beginning with a digit
* Example using `any` with `where true`

* Remove references to `event_type_field` default

* Reuse "Events starting with digits" section

* Updates for #53073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants