Add file type-based exclusion setting for searchable snapshots cache #53492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for example to configure searchable snapshots to avoid caching certain types of files, for example stored fields.
ywelsch
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
LGTM, thanks this change @ywelsch. I left few minor comments.
I was about to do a similar change but I put it on hold as I'm more and more tempted to merge CacheDirectory and SearchableSnapshotDirectory together and rely on something like CachedIndexInput and DirectIndexInput objects. I suspect it would simplify things and would allow stats for cached/non cached reads (because this PR shortcut the stats for blacklisted files and I think it is still valuable to have them as direct reads). Anyway, this should not block this PR.
...hable-snapshots/src/main/java/org/elasticsearch/index/store/SearchableSnapshotDirectory.java
Outdated
Show resolved
Hide resolved
...napshots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/CacheDirectory.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshotsIntegTests.java
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobContainer.java
Outdated
Show resolved
Hide resolved
…nto snapshot-cache-blacklist
…nto snapshot-cache-blacklist
…nto snapshot-cache-blacklist
…nto snapshot-cache-blacklist
|
@elasticmachine update branch |
tlrx
approved these changes
Mar 27, 2020
ywelsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuring searchable snapshots to avoid caching certain types of files, for example "fdt" files for stored fields.