[ML] Extend classification to support multiple classes #53539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
force-pushed
the
extend-classification-to-support-multiclass
branch
from
10c4d7e to
367cfd6
Compare
Prepares classification analysis to support more than just two classes. It introduces a new parameter to the process config which dictates the `num_classes` to the process. It also changes the max classes limit to `30` provisionally.
| @@ -272,7 +275,7 @@ public boolean supportsCategoricalFields() { | |||
| @Override | |||
| public List<FieldCardinalityConstraint> getFieldCardinalityConstraints() { | |||
| // This restriction is due to the fact that currently the C++ backend only supports binomial classification. | |||
| return Collections.singletonList(FieldCardinalityConstraint.between(dependentVariable, 2, 2)); | |||
| return Collections.singletonList(FieldCardinalityConstraint.between(dependentVariable, 2, 30)); | |||
There was a problem hiding this comment.
Should 30 become a constant in this class?
...-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ClassificationIT.java
Show resolved
Hide resolved
x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/extractor/ExtractedFieldsTests.java
Show resolved
Hide resolved
dimitris-athanasiou
deleted the
extend-classification-to-support-multiclass
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares classification analysis to support more than just
two classes. It introduces a new parameter to the process config
which dictates the
num_classesto the process. It alsochanges the max classes limit to
30provisionally.