Skip to content

[7.x] Fix ingest pipeline _simulate api with empty docs never returns a response #53547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danhermann
Copy link
Contributor

This PR relates to #52833.

The main changes are:

Return 400 status code with error message if the docs array is empty.
Return 400 status code with error message if the element in docs array is not a map.
Check whether the docs array is empty again when executing the pipeline simulate, avoiding no response.
Add some test code for the changes.

Backport of #52937

@danhermann danhermann added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP backport v7.7.0 labels Mar 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@danhermann danhermann merged commit fb29c2d into elastic:7.x Mar 13, 2020
@danhermann danhermann deleted the backport_52937_pipeline_simulate_without_docs branch March 13, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants