-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Wildcard field - add normalizer support #53851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-search (:Search/Mapping) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment but adding the support for this option makes sense to me.
...ugin/wildcard/src/main/java/org/elasticsearch/xpack/wildcard/mapper/WildcardFieldMapper.java
Outdated
Show resolved
Hide resolved
594a545
to
2d3172c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left 2 more comments
...ugin/wildcard/src/main/java/org/elasticsearch/xpack/wildcard/mapper/WildcardFieldMapper.java
Outdated
Show resolved
Hide resolved
...ugin/wildcard/src/main/java/org/elasticsearch/xpack/wildcard/mapper/WildcardFieldMapper.java
Outdated
Show resolved
Hide resolved
Good to go, @jimczi ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…erns and checkCompatibility
46439ec
to
4f242fc
Compare
Backport to 7x pending on #53512 |
* Add support for normalisation to wildcard field * Tidied imports * Added docs about params * Fix outdated error message * Avoid normaliser butchering wildcard query special characters * Fix broken test expectations * Fix wrong toString method * Address review comments - common method for normalising wildcard patterns and checkCompatibility * Remove unused import
…tic#54109)" This reverts commit 6a60f85.
…tic#54109)" This reverts commit 6a60f85.
Add normalizer support for the wildcard field to allow case insensitivity