Extract CacheBufferedIndexInput from CacheDirectory #53879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
commented
Mar 20, 2020
...src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/CacheBufferedIndexInput.java
Show resolved
Hide resolved
DaveCTurner
reviewed
Mar 20, 2020
...-snapshots/src/main/java/org/elasticsearch/index/store/BaseSearchableSnapshotIndexInput.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/CacheBufferedIndexInput.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/CacheBufferedIndexInput.java
Outdated
Show resolved
Hide resolved
DaveCTurner
approved these changes
Mar 20, 2020
| @@ -48,6 +50,8 @@ | |||
| */ | |||
| public class SearchableSnapshotIndexInput extends BaseSearchableSnapshotIndexInput { | |||
|
|
|||
| private static final Logger logger = LogManager.getLogger(SearchableSnapshotIndexInput.class); | |||
There was a problem hiding this comment.
This isn't used? I mean it probably will be in future, but I think I'd prefer to add it when it's needed.
|
Thanks David |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #53860, this pull request extracts the
CacheBufferedIndexInputclass from theCacheDirectoryso that it can be merged withSearchableSnapshotDirectory.