Skip to content

Restrict template name when putting index template #53970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Restrict template name when putting index template #53970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ain/java/org/elasticsearch/action/admin/indices/template/put/PutIndexTemplateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ public ActionRequestValidationException validate() {
ActionRequestValidationException validationException = null;
if (name == null) {
validationException = addValidationError("name is missing", validationException);
} else if (name.contains("*")) {
validationException = addValidationError("may not contain an asterisk", validationException);
}
if (indexPatterns == null || indexPatterns.size() == 0) {
validationException = addValidationError("index patterns are missing", validationException);
Expand Down
5 changes: 5 additions & 0 deletions ...ava/org/elasticsearch/action/admin/indices/template/put/PutIndexTemplateRequestTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ public void testValidateErrorMessage() {
request.patterns(Collections.singletonList("test-*"));
ActionRequestValidationException noError = request.validate();
assertThat(noError, is(nullValue()));

request.name("*");
ActionRequestValidationException badIndexTemplateName = request.validate();
assertThat(badIndexTemplateName.validationErrors(), hasSize(1));
assertThat(badIndexTemplateName.getMessage(), containsString("may not contain an asterisk"));
}

public void testMappingKeyedByType() throws IOException {
Expand Down