Rename SearchableSnapshotIndexInput and move cache classes into store package #54075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
DaveCTurner
reviewed
Mar 25, 2020
This is a good suggestion, I use it to rename the classes. Let me know what you think. |
DaveCTurner
approved these changes
Mar 27, 2020
|
|
||
| import org.elasticsearch.ElasticsearchException; | ||
| import org.elasticsearch.action.ActionListener; | ||
| import org.elasticsearch.cluster.coordination.DeterministicTaskQueue; | ||
| import org.elasticsearch.common.settings.Settings; | ||
| import org.elasticsearch.index.store.cache.SparseFileTracker; |
There was a problem hiding this comment.
Strange, this import is unnecessary but checkstyle is happy.
There was a problem hiding this comment.
Looks like a checkstyle limitation :/ I removed it in df9bc92
|
Thanks David |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request suggests to rename the
SearchableSnapshotIndexInputclass toDirectBufferedIndexInput(in comparison toCacheBufferedIndexInput) and places it into aorg.elasticsearch.index.store.directpackage.It also moves
CacheBufferedIndexInputand associated classes to theorg.elasticsearch.index.store.cachepackage so that it is colocated with thedirectpackage.The
IndexInputStatsclass is moved toorg.elasticsearch.index.store.