Defer repo ops in searchable snapshot restore #54211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A searchable snapshots `Directory` requires a `BlobContainer` and a `BlobStoreIndexShardSnapshot`, which require us to read some data from the repository. Today we construct these objects on the cluster applier thread, blocking that thread on remote operations. This commit defers their construction until the restore process starts, so that they can happen on a more appropriate thread. It also reinstates the assertion that constructing the blob container only occurs on the snapshot or generic threadpool, and adds an assertion that blobs are only accessed on snapshot or generic or search threads too.
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
approved these changes
Mar 31, 2020
|
|
||
| // Today processExistingRecoveries considers all shards and constructs a shard store snapshot on this thread, this needs | ||
| // addressing. TODO NORELEASE | ||
| || threadName.contains('[' + ThreadPool.Names.FETCH_SHARD_STORE + ']') |
...hable-snapshots/src/main/java/org/elasticsearch/index/store/SearchableSnapshotDirectory.java
Outdated
Show resolved
Hide resolved
…arch/index/store/SearchableSnapshotDirectory.java Co-Authored-By: Tanguy Leroux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A searchable snapshots
Directoryrequires aBlobContainerand aBlobStoreIndexShardSnapshot, which require us to read some data from therepository. Today we construct these objects on the cluster applier thread,
blocking that thread on remote operations.
This commit defers their construction until the restore process starts, so that
they can happen on a more appropriate thread. It also reinstates the assertion
that constructing the blob container only occurs on the snapshot or generic
threadpool, and adds an assertion that blobs are only accessed on snapshot or
generic or search threads too.