Skip to content

[6.8] Disallow negative TimeValues (#53913) #54304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 27, 2020
Merged

[6.8] Disallow negative TimeValues (#53913) #54304

merged 5 commits into from
Mar 27, 2020

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Mar 26, 2020

Backports the following commits to 6.8:

gwbrown added 4 commits March 26, 2020 10:10
@gwbrown
Disallow negative TimeValues (elastic#53913)
3543e96 
This commit causes negative TimeValues, other than -1 which is sometimes used as
a sentinel value, to be rejected during parsing.

Also introduces a hack to allow ILM to load policies which were written to the
cluster state with a negative min_age, treating those values as 0, which should
match the behavior of prior versions.
@gwbrown
Re-apply IndexLifecycleRunner changes lost in merge
74b71f8
@gwbrown
Make SnapshotStatsTests generate more realistic times
e403b28
@gwbrown
Fix negative TimeValue in deprecation test
b528a94
@gwbrown
Copy link
Contributor Author

gwbrown commented Mar 26, 2020

@elasticmachine test this please

@gwbrown gwbrown added the v6.8.9 label Mar 27, 2020
@gwbrown
Copy link
Contributor Author

gwbrown commented Mar 27, 2020

@elasticmachine test this please

@gwbrown gwbrown merged commit d5293ea into elastic:6.8 Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport v6.8.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gwbrown