Add Azure support for ranged read blob operations #54358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
original-brownbear
approved these changes
Mar 30, 2020
| @@ -128,7 +135,7 @@ private BlobContainer createBlobContainer(final int maxRetries) { | |||
| final AzureStorageService service = new AzureStorageService(clientSettings.build()) { | |||
| @Override | |||
| RetryPolicyFactory createRetryPolicy(final AzureStorageSettings azureStorageSettings) { | |||
| return new RetryExponentialRetry(1, 100, 500, azureStorageSettings.getMaxRetries()); | |||
| return new RetryExponentialRetry(1, 10, 100, azureStorageSettings.getMaxRetries()); | |||
There was a problem hiding this comment.
Why make this way more aggressive? I don't see the harm in doing so ... seems like we don't need these long timeout here, just wondering? :)
There was a problem hiding this comment.
While looking at this class I found them a bit high, specially when a high number of retries (5) is picked up so I lowered them. If that causes any issue on CI I'll restore the previous values.
...azure/src/test/java/org/elasticsearch/repositories/azure/AzureBlobContainerRetriesTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/1 (unrelated failure) |
|
Thanks a lot Armin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for ranged read blob operations to the repository azure plugin. It adds the necessary plumbing down to the Azure SDK with additionnal unit tests and also adds a QA test for searchable snapshots.
Relates #50999