Handle -1 gc_threshold settings explicitly #54546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because -1 is technically a valid TimeValue (as a sentinel value), that is now explicitly checked for when validating gc_thresholds. The tests are also adjusted to test this case separately from other negative values.
gwbrown
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Apr 1, 2020
Because -1 is technically a valid TimeValue (as a sentinel value), that is now explicitly checked for when validating gc_thresholds. The tests are also adjusted to test this case separately from other negative values.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Apr 1, 2020
Because -1 is technically a valid TimeValue (as a sentinel value), that is now explicitly checked for when validating gc_thresholds. The tests are also adjusted to test this case separately from other negative values.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Apr 1, 2020
Because -1 is technically a valid TimeValue (as a sentinel value), that is now explicitly checked for when validating gc_thresholds. The tests are also adjusted to test this case separately from other negative values.
gwbrown
added a commit
that referenced
this pull request
Apr 1, 2020
Because -1 is technically a valid TimeValue (as a sentinel value), that is now explicitly checked for when validating gc_thresholds. The tests are also adjusted to test this case separately from other negative values.
gwbrown
added a commit
that referenced
this pull request
Apr 1, 2020
Because -1 is technically a valid TimeValue (as a sentinel value), that is now explicitly checked for when validating gc_thresholds. The tests are also adjusted to test this case separately from other negative values.
gwbrown
added a commit
that referenced
this pull request
Apr 1, 2020
Because -1 is technically a valid TimeValue (as a sentinel value), that is now explicitly checked for when validating gc_thresholds. The tests are also adjusted to test this case separately from other negative values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because -1 is technically a valid TimeValue (as a sentinel value), that is now
explicitly checked for when validating gc_thresholds. The tests are also
adjusted to test this case separately from other negative values.
Follow-up to #53913
Fixes #54485