Skip to content

ILM MountSnapshotStep: use correct logic operator #54675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2020
Merged

ILM MountSnapshotStep: use correct logic operator #54675

merged 5 commits into from
Apr 3, 2020

Conversation

andreidan
Copy link
Contributor

No description provided.

@andreidan andreidan added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Apr 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@andreidan andreidan requested a review from dakrone April 2, 2020 18:37
dakrone
dakrone approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good catch, is there any way we can test this so we don't break it again accidentally in the future?

@andreidan
Copy link
Contributor Author

@elasticmachine update branch

@andreidan
Copy link
Contributor Author

@elasticmachine update branch

@andreidan
Copy link
Contributor Author

@dakrone good shout. added a couple of tests and fix some leftover assertions on this occasion

@andreidan andreidan merged commit 34d3478 into elastic:feature/searchable-snapshots Apr 3, 2020
@tlrx tlrx mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreidan @elasticmachine @dakrone