Improve agg reduce tests #54910
Merged
Improve agg reduce tests #54910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows subclasses of `InternalAggregationTestCase` to make a `List` of values to reduce so that it can make values that are realistic *together*. The first use of this is with `InternalTTest` which uses it to make results that don't cause their `sum` field to wrap. It'd likely be useful for a ton of other aggs but just one for now.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 7, 2020
This allows subclasses of `InternalAggregationTestCase` to make a `List` of values to reduce so that it can make values that are realistic *together*. The first use of this is with `InternalTTest` which uses it to make results that don't cause their `sum` field to wrap. It'd likely be useful for a ton of other aggs but just one for now.
nik9000
added a commit
that referenced
this pull request
Apr 7, 2020
This allows subclasses of `InternalAggregationTestCase` to make a `List` of values to reduce so that it can make values that are realistic *together*. The first use of this is with `InternalTTest` which uses it to make results that don't cause their `sum` field to wrap. It'd likely be useful for a ton of other aggs but just one for now.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 8, 2020
We added a fancy method to provide random realistic test data to the reduction tests in elastic#54910. This uses that to remove some of the more esoteric machinations in the agg tests. This will marginally increase the coverage of the serialiation tests and, more importantly, remove some mysterious value generation code that only really made sense for random reduction tests but was used all over the place. It doesn't, on the other hand, make the tests shorter. Just *hopefully* more clear. I only cleaned up a few tests this way. If we like this it'd probably be worth grabbing others.
nik9000
added a commit
that referenced
this pull request
Apr 10, 2020
We added a fancy method to provide random realistic test data to the reduction tests in #54910. This uses that to remove some of the more esoteric machinations in the agg tests. This will marginally increase the coverage of the serialiation tests and, more importantly, remove some mysterious value generation code that only really made sense for random reduction tests but was used all over the place. It doesn't, on the other hand, make the tests shorter. Just *hopefully* more clear. I only cleaned up a few tests this way. If we like this it'd probably be worth grabbing others.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 10, 2020
We added a fancy method to provide random realistic test data to the reduction tests in elastic#54910. This uses that to remove some of the more esoteric machinations in the agg tests. This will marginally increase the coverage of the serialiation tests and, more importantly, remove some mysterious value generation code that only really made sense for random reduction tests but was used all over the place. It doesn't, on the other hand, make the tests shorter. Just *hopefully* more clear. I only cleaned up a few tests this way. If we like this it'd probably be worth grabbing others.
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Apr 10, 2020
A small follow-up to elastic#54910. Now that we can generated consistent set of internal aggs to reduce, we no longer need to keep agg parameters as class variables. Related to elastic#54910
nik9000
added a commit
that referenced
this pull request
Apr 10, 2020
We added a fancy method to provide random realistic test data to the reduction tests in #54910. This uses that to remove some of the more esoteric machinations in the agg tests. This will marginally increase the coverage of the serialiation tests and, more importantly, remove some mysterious value generation code that only really made sense for random reduction tests but was used all over the place. It doesn't, on the other hand, make the tests shorter. Just *hopefully* more clear. I only cleaned up a few tests this way. If we like this it'd probably be worth grabbing others.
imotov
added a commit
that referenced
this pull request
Apr 13, 2020
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Apr 13, 2020
A small follow-up to elastic#54910. Now that we can generated consistent set of internal aggs to reduce, we no longer need to keep agg parameters as class variables. Related to elastic#54910
imotov
added a commit
that referenced
this pull request
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows subclasses of
InternalAggregationTestCaseto make aListof values to reduce so that it can make values that are realistic
together. The first use of this is with
InternalTTestwhich uses itto make results that don't cause their
sumfield to wrap. It'd likelybe useful for a ton of other aggs but just one for now.