Skip to content

Add allowed warnings to index template composition tests #54916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Apr 7, 2020

We occasionally add a global template for our YAML tests, and this can cause warnings for these
template tests. This commit adds these warnings so they don't cause test failures.

Resolves #54822

We occasionally add a global template for our YAML tests, and this can cause warnings for these
template tests. This commit adds these warnings so they don't cause test failures.

Resolves elastic#54822
@dakrone dakrone added :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 v7.8.0 labels Apr 7, 2020
@dakrone dakrone requested review from martijnvg and probakowski April 7, 2020 18:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@dakrone
Copy link
Member Author

dakrone commented Apr 7, 2020

@elasticmachine update branch

@dakrone dakrone requested a review from andreidan April 8, 2020 15:01
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this Lee

@dakrone dakrone merged commit c7dc033 into elastic:master Apr 8, 2020
@dakrone dakrone deleted the itv2-add-more-allowed-warnings branch April 8, 2020 15:22
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Apr 8, 2020
We occasionally add a global template for our YAML tests, and this can cause warnings for these
template tests. This commit adds these warnings so they don't cause test failures.

Resolves elastic#54822

Co-authored-by: Elastic Machine <[email protected]>
@pugnascotia pugnascotia added the >test Issues or PRs that are addressing/adding tests label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Component and index template composition fails
5 participants