Skip to content

Fix Broken Math in S3 Retries Tests #54952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

original-brownbear
Copy link
Contributor

If we run into length == 0 we trip an assertion in randomIntBetween(0, length -1).

If we run into `length == 0` we trip an assertion in `randomIntBetween(0, length -1)`.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.8.0 labels Apr 8, 2020
@original-brownbear original-brownbear requested a review from tlrx April 8, 2020 13:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear
Copy link
Contributor Author

Jenkins run elasticsearch-ci/packaging-sample-unix-archives
Jenkins run elasticsearch-ci/packaging-sample-unix-packages

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear original-brownbear merged commit 73b5f58 into elastic:master Apr 8, 2020
@original-brownbear original-brownbear deleted the fix-broken-math-s3-retries-tests branch April 8, 2020 17:41
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Apr 8, 2020
If we run into `length == 0` we trip an assertion in `randomIntBetween(0, length -1)`.
original-brownbear added a commit that referenced this pull request Apr 8, 2020
If we run into `length == 0` we trip an assertion in `randomIntBetween(0, length -1)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants