Remove ban tasks with the current thread context #55404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
the
:Distributed Coordination/Task Management
|
Pinging @elastic/es-distributed (:Distributed/Task Management) |
ywelsch
approved these changes
Apr 17, 2020
...ava/org/elasticsearch/action/admin/cluster/node/tasks/cancel/TransportCancelTasksAction.java
Show resolved
Hide resolved
|
Thanks Yannick! |
dnhatn
added a commit
that referenced
this pull request
Apr 17, 2020
If we start unbanning when the last child task completed and that child task executed with a specific user, then unban requests are denied because internal requests can't run with a user. We need to remove bans with the current thread context.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jun 11, 2020
If the task runs with a user, and it's canceled after we have sent ban requests, then the unban request will be denied as it must not execute with a user. We need to wrap it with the current thread context.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jun 11, 2020
If the task runs with a user, and it's canceled after we have sent ban requests, then the unban request will be denied as it must not execute with a user. We need to wrap it with the current thread context.
This was referenced Jun 11, 2020
dnhatn
added a commit
that referenced
this pull request
Jun 11, 2020
If a task runs with a user, and it's canceled after we have sent the ban requests, then the unban request will be denied as it must not execute with a user. We need to wrap it with the current thread context. Backport of #55404
dnhatn
added a commit
that referenced
this pull request
Jun 11, 2020
If a task runs with a user, and it's canceled after we have sent the ban requests, then the unban request will be denied as it must not execute with a user. We need to wrap it with the current thread context. Backport of #55404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning is for an unban request, not a ban request as we do not have a corresponding log in TransportCancelTasksAction.
If we start unbanning when the last child task completed and that child task executed with a specific user, then unban requests are denied because internal requests can't run with a user. We need to remove bans with the current thread context.
Labelled this non-issue for an unreleased bug.