[ML] Fix log spam and disable ILM/SLM history for native ML tests #55459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
droberts195
reviewed
Apr 20, 2020
| @@ -191,10 +190,6 @@ protected boolean upgradeMode() { | |||
| return client().execute(PutFilterAction.INSTANCE, new PutFilterAction.Request(filter)).actionGet(); | |||
| } | |||
|
|
|||
| protected GetFiltersAction.Response getMlFilters() { | |||
| return client().execute(GetFiltersAction.INSTANCE, new GetFiltersAction.Request()).actionGet(); | |||
| } | |||
There was a problem hiding this comment.
Why does this method have to be removed as part of this PR?
There was a problem hiding this comment.
It doesn't have to be. But it was unused and I was exploring this class for fixing this problem.
Following the boy scout rule
droberts195
changed the title
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 20, 2020
This adds a dependency to ingest common. This removes the log spam resulting from basic plugins being enabled that require the common ingest processors.
benwtrent
added a commit
that referenced
this pull request
Apr 20, 2020
…ts (#55475) * [ML] fix native ML test log spam (#55459) This adds a dependency to ingest common. This removes the log spam resulting from basic plugins being enabled that require the common ingest processors. * removing unnecessary changes * removing unused imports * removing unnecessary java setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dependency to ingest common. This removes the log spam resulting from basic plugins being enabled that require the common ingest processors.