-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Disable monitoring in ML multinode tests #55461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable monitoring in ML multinode tests #55461
Conversation
Removing the deprecated "xpack.monitoring.enabled" setting introduced log spam and potentially some failures in ML tests. It's possible to use a different, non-deprecated setting to disable monitoring, so we do that here.
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
There is also a place in Java code where ML is disabling monitoring using the deprecated setting: Line 135 in 92c8a73
Should that also be flipped over to using In fact, if you search for usages of |
@droberts195 I was thinking of doing those in a follow-up PR but I'll go ahead and handle them here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of doing those in a follow-up PR
@williamrandolph if you think there's a risk of breaking other things then a follow-up PR is fine with me.
LGTM for the changes so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me :)
Removing the deprecated "xpack.monitoring.enabled" setting introduced log spam and potentially some failures in ML tests. It's possible to use a different, non-deprecated setting to disable monitoring, so we do that here.
Backported to 7.x: 7817948 |
Removing the deprecated "xpack.monitoring.enabled" setting introduced log spam and potentially some failures in ML tests. It's possible to use a different, non-deprecated setting to disable monitoring, so we do that here.
Relates #55420
Relates #54816