EQL: reject queries that use a nested field or a sub-field of a nested field #55721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
field types in their hierarchy.
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
costin
approved these changes
May 3, 2020
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
May 4, 2020
…types in their hierarchy (elastic#55721) (cherry picked from commit 2a02446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested type fields were rejected in the wrong place in code (when the ES query was built). And this even if the query itself was not using any nested fields.
This PR fixes #55679 by allowing nested fields in the response and, also, rejects nested type fields in queries.