Convert remaining license methods to isAllowed #55908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit converts the remaining isXXXAllowed methods to instead of use isAllowed with a Feature value. There are a couple other methods that are static, as well as some licensed features that check the license directly, but those will be dealt with in other followups.
rjernst
added
>refactoring
:Security/License
|
Pinging @elastic/es-security (:Security/License) |
tvernum
approved these changes
Apr 29, 2020
|
|
||
| MACHINE_LEARNING(OperationMode.PLATINUM, true), | ||
|
|
||
| TRANSFORM(OperationMode.MISSING, true), |
There was a problem hiding this comment.
I don't love the use of MISSING here - I think it will confuse future readers and those who are trying to add Basic licensed features, but I think the solution is to remove MISSING entirely in a separate PR. I don't think we need to retain it as an operation mode.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 30, 2020
This commit converts the remaining isXXXAllowed methods to instead of use isAllowed with a Feature value. There are a couple other methods that are static, as well as some licensed features that check the license directly, but those will be dealt with in other followups.
rjernst
added a commit
that referenced
this pull request
Apr 30, 2020
This commit converts the remaining isXXXAllowed methods to instead of use isAllowed with a Feature value. There are a couple other methods that are static, as well as some licensed features that check the license directly, but those will be dealt with in other followups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit converts the remaining isXXXAllowed methods to instead of
use isAllowed with a Feature value. There are a couple other methods
that are static, as well as some licensed features that check the
license directly, but those will be dealt with in other followups.