[ML] Remove error on parsing progress for unknown phase in DFA #55926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On second thought, this check does not seem to be adding value. We can test that the phases are as we expect them for each analysis by adding yaml tests. Those would fail if we introduce new phases from c++ accidentally or without coordination. This would achieve the same thing. At the same time we would not have to comment out this code each time a new phase is introduced. Instead we can just temporarily mute those yaml tests. Note I will add those tests right after the imminent new phases are added to the c++ side.
|
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
added a commit
that referenced
this pull request
Apr 29, 2020
…55926) (#55954) On second thought, this check does not seem to be adding value. We can test that the phases are as we expect them for each analysis by adding yaml tests. Those would fail if we introduce new phases from c++ accidentally or without coordination. This would achieve the same thing. At the same time we would not have to comment out this code each time a new phase is introduced. Instead we can just temporarily mute those yaml tests. Note I will add those tests right after the imminent new phases are added to the c++ side. Backport of #55926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On second thought, this check does not seem to be adding value.
We can test that the phases are as we expect them for each analysis
by adding yaml tests. Those would fail if we introduce new phases
from c++ accidentally or without coordination. This would achieve
the same thing. At the same time we would not have to comment out
this code each time a new phase is introduced. Instead we can just
temporarily mute those yaml tests. Note I will add those tests
right after the imminent new phases are added to the c++ side.