Fix input snapshotting for test tasks #55981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
reviewed
Apr 29, 2020
| @@ -269,7 +276,7 @@ public static void configureTestTasks(Project project) { | |||
| "-XX:+HeapDumpOnOutOfMemoryError" | |||
| ); | |||
|
|
|||
| test.getJvmArgumentProviders().add(() -> List.of("-XX:HeapDumpPath=$heapdumpDir")); | |||
| test.getJvmArgumentProviders().add(new SimpleCommandLineArgumentProvider("-XX:HeapDumpPath=$heapdumpDir")); | |||
There was a problem hiding this comment.
Oh, there is a bug here due to my previous PR, can you fix? heapdumpDir is a variable here that needs to be resolved, not a literal in the setting value.
There was a problem hiding this comment.
Good catch! Fixed.
mark-vieira
added a commit
that referenced
this pull request
Apr 29, 2020
(cherry picked from commit 3b7ae2d)
mark-vieira
added a commit
that referenced
this pull request
Apr 29, 2020
(cherry picked from commit 3b7ae2d)
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting some of our build logic from Groovy to Java in #55834, we inadvertently broke incremental build and cacheability because Gradle cannot reliably snapshot lambda task inputs. This PR replaces those lambdas with either a normal class or anonymous inner class implementation.