-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Improve same-shard allocation explanations #56010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve same-shard allocation explanations #56010
Conversation
I see occasional confusion about the explanations emitted by the same-shard allocation decider, particularly amongst new users setting up a single-node cluster and trying to determine why their cluster has `yellow` health. For example: the shard cannot be allocated to the same node on which a copy of the shard already exists This is technically correct but it's quite a complicated sentence. Also, by starting with "the shard cannot be allocated" it makes it sound like this is the problem, whereas in fact this message is a good thing and users should typically focus their attention elsewhere. This commit simplifies the wording of these messages and makes them sound more positive, for example: a copy of this shard is already allocated to this node
Pinging @elastic/es-distributed (:Distributed/Allocation) |
See for instance some forum posts that use this message for their title: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this sounds clearer to me too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for making these changes.
Thanks both 😄 |
I see occasional confusion about the explanations emitted by the same-shard allocation decider, particularly amongst new users setting up a single-node cluster and trying to determine why their cluster has `yellow` health. For example: the shard cannot be allocated to the same node on which a copy of the shard already exists This is technically correct but it's quite a complicated sentence. Also, by starting with "the shard cannot be allocated" it makes it sound like this is the problem, whereas in fact this message is a good thing and users should typically focus their attention elsewhere. This commit simplifies the wording of these messages and makes them sound more positive, for example: a copy of this shard is already allocated to this node
I see occasional confusion about the explanations emitted by the same-shard
allocation decider, particularly amongst new users setting up a single-node
cluster and trying to determine why their cluster has
yellow
health. Forexample:
This is technically correct but it's quite a complicated sentence. Also, by
starting with "the shard cannot be allocated" it makes it sound like this is
the problem, whereas in fact this message is a good thing and users should
typically focus their attention elsewhere.
This commit simplifies the wording of these messages and makes them sound more
positive, for example: