SQL: Add BigDecimal support to JDBC #56015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the getBigDecimal() methods.
A prepared statement will now accept a BigDecimal parameter as a proxy for a double, if the conversion is lossless.
bpintea
commented
Apr 30, 2020
Comment on lines
-24
to
-28
| index("library", builder -> { | ||
| builder.field("name", "Don Quixote"); | ||
| builder.field("page_count", 1072); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I've removed an index involvement mostly due to #56013. Using an index for this test doesn't seem to bring any particular value, but can revert if I'm missing anything.
- adjust unchanged line to newly enforced line limit
Remove wrongly added chunk.
|
Pinging @elastic/es-ql (:Query Languages/SQL) |
costin
approved these changes
May 4, 2020
| @@ -547,7 +550,9 @@ public InputStream getBinaryStream(int columnIndex) throws SQLException { | |||
| @Override | |||
| @Deprecated | |||
| public BigDecimal getBigDecimal(String columnLabel, int scale) throws SQLException { | |||
| throw new SQLFeatureNotSupportedException("BigDecimal not supported"); | |||
| BigDecimal bd = getBigDecimal(columnLabel); | |||
There was a problem hiding this comment.
Why not delegate to the other getBigDecimal -> return getBigDecimal(column(columnLabel), scale) ?
There was a problem hiding this comment.
Right, good point! Thanks.
matriv
approved these changes
May 4, 2020
x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/jdbc/ResultSetTestCase.java
Outdated
Show resolved
Hide resolved
| put(Long.class, Types.BIGINT); | ||
| put(Float.class, Types.REAL); | ||
| put(Double.class, Types.DOUBLE); | ||
| // TODO: no half & scaled float testing |
There was a problem hiding this comment.
It probably should be done indeed, but I was thinking to keep it focused on BigDecimal for now, since adding coverage for half- and scaled- floats would require extending the testing for the rest of the types too.
Remove code duplicate in getBigDecimal(String columnLabel, int scale).
…/qa/jdbc/ResultSetTestCase.java Co-authored-by: Marios Trivyzas <[email protected]>
Disable the deprecation-API usage failure, since this is used to implement a deprecated API itself.
…h into enh/jdbc_bigdecimal
bpintea
added a commit
that referenced
this pull request
May 5, 2020
* SQL: Add BigDecimal support to JDBC (#56015) * Introduce BigDecimal support to JDBC -- fetching This commit adds support for the getBigDecimal() methods. * Allow BigDecimal params in double range A prepared statement will now accept a BigDecimal parameter as a proxy for a double, if the conversion is lossless. (cherry picked from commit e9a873a) * Fix compilation error Dimond notation with anonymous inner classes not avail in Java8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the JDBC support for BigDecimals. This is limited however, since ES support for this type is limited.
Fetching BigDecimals works with no restrictions, since all ES native and SQL numeric (and boolean) types can be accommodated by a BigDecimal.
Setting a BigDecimal value for a parameter in a prepared statement is limited to what a double can encode.
Closes #43806